Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ascii function to datafusion_functions #9740

Merged
merged 6 commits into from
Mar 22, 2024
Merged

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Mar 22, 2024

Which issue does this PR close?

Closes #9533.

Rationale for this change

As part of #9285 the string functions should be migrated to the new datafusion-functions crate in the new structure

What changes are included in this PR?

Move ascii function to datafusion_functions

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Signed-off-by: Chojan Shang <psiace@apache.org>
@github-actions github-actions bot added logical-expr Logical plan and expressions physical-expr Physical Expressions labels Mar 22, 2024
PsiACE added 3 commits March 23, 2024 00:36
Signed-off-by: Chojan Shang <psiace@apache.org>
Signed-off-by: Chojan Shang <psiace@apache.org>
Signed-off-by: Chojan Shang <psiace@apache.org>
@PsiACE PsiACE marked this pull request as ready for review March 22, 2024 16:51
@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Mar 22, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @PsiACE -- looks great to me 🙏

@alamb
Copy link
Contributor

alamb commented Mar 22, 2024

I merged up from main to resolve conflicts on this branch

@alamb alamb merged commit 6c63051 into apache:main Mar 22, 2024
23 checks passed
@alamb
Copy link
Contributor

alamb commented Mar 22, 2024

Thanks again

@PsiACE PsiACE deleted the string-functions branch March 23, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logical-expr Logical plan and expressions physical-expr Physical Expressions sqllogictest SQL Logic Tests (.slt)
Projects
None yet
2 participants