feat: Between expr to sql string #9803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Thank you for the contribution @sebastian2296. Once CI passes this PR looks good to me
datafusion/sql/src/unparser/expr.rs
Outdated
| @@ -711,6 +724,15 @@ mod tests { | |||
| Expr::IsUnknown(Box::new((col("a") + col("b")).gt(lit(4)))), | |||
| r#"(("a" + "b") > 4) IS UNKNOWN"#, | |||
| ), | |||
| ( | |||
| Expr::Between(Between { | |||
There was a problem hiding this comment.
I think you could write this more concisely using https://docs.rs/datafusion/latest/datafusion/logical_expr/enum.Expr.html#method.between
so like betwen(col("a:"), lit(1), lit(7))
|
Hi @sebastian2296 -- I think you need to run |
|
Beautiful -- thank you @sebastian2296 |
Lordworms
pushed a commit
to Lordworms/arrow-datafusion
that referenced
this pull request
Apr 1, 2024
* feat: Between expr to sql string * fix: use between logical expr * fix: format using fmt * fix: remove redundant field name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR adds support to convert Between Expr to SQL string #9726
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?