move Atan2, Atan, Acosh, Asinh, Atanh to datafusion-function
#9872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
43 tasks
alamb
reviewed
Mar 30, 2024
| @@ -37,16 +37,8 @@ use strum_macros::EnumIter; | |||
| #[derive(Debug, Clone, PartialEq, Eq, Hash, EnumIter, Copy)] | |||
| pub enum BuiltinScalarFunction { | |||
| // math functions | |||
| /// atan | |||
| Atan, | |||
| /// atan2 | |||
| Atan2, | |||
There was a problem hiding this comment.
any particular reason that you did not migrate Atan2?
| --ProjectionExec: expr=[atan(c11@0) as atan_c11] | ||
| ----RepartitionExec: partitioning=RoundRobinBatch(4), input_partitions=1 | ||
| ------CsvExec: file_groups={1 group: [[WORKSPACE_ROOT/testing/data/csv/aggregate_test_100.csv]]}, projection=[c11], output_ordering=[c11@0 ASC NULLS LAST], has_header=true | ||
| --SortExec: expr=[atan_c11@0 ASC NULLS LAST] |
There was a problem hiding this comment.
This test seems to show a regression (there is now a sort in it).
I wonder if the issue is that you need to specify montononicity (which is now possible after #9869 from @tinfoil-knight )?
|
Marking as draft as I think this PR is no longer waiting on feedback. Please mark it as ready for review when it is ready for another look |
Weijun-H
force-pushed
the
move-Atan-Acosh-Asinh-Atanh
branch
from
887c48f
to
a77e882
Compare
Weijun-H
changed the title
Atan, Acosh, Asinh, Atanh to datafusion-functionAtan2, Atan, Acosh, Asinh, Atanh to datafusion-function
alamb
approved these changes
Mar 31, 2024
| @@ -68,6 +68,9 @@ get_optimal_return_type!(utf8_to_str_type, DataType::LargeUtf8, DataType::Utf8); | |||
| // `utf8_to_int_type`: returns either a Int32 or Int64 based on the input type size. | |||
| get_optimal_return_type!(utf8_to_int_type, DataType::Int64, DataType::Int32); | |||
|
|
|||
| /// Creates a scalar function implementation for the given function. | |||
| signature: Signature, | ||
| } | ||
|
|
||
| impl Atan2 { |
There was a problem hiding this comment.
Maybe if we have more two argument math functions we can eventually macroize this like we have a macro for single argument functions
|
merging this quickly to keep the train going and minimize potential conflicts |
Lordworms
pushed a commit
to Lordworms/arrow-datafusion
that referenced
this pull request
Apr 1, 2024
…on` (apache#9872) * Refactor math functions in datafusion code * fic ci * fix: avoid regression * refactor: move atan2 function * chore: move atan2 test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Relates #9285
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?