[Fix-3536][api]If user didn't have tenant,create resource directory w…

…ill NPE (#3537)

* [Fix-3536][api]If user didn't have tenant,create resource will NPE

* [Fix-3536][api]If user didn't have tenant,create resource directory will NPE

dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ResourcesService.java

@@ -103,7 +103,10 @@ public Result createDirectory(User loginUser,
  return result;
  }
  String fullName = currentDir.equals("/") ? String.format("%s%s",currentDir,name):String.format("%s/%s",currentDir,name);
-
+ result = verifyResourceName(fullName,type,loginUser);
+ if (!result.getCode().equals(Status.SUCCESS.getCode())) {
+ return result;
+ }
  if (pid != -1) {
  Resource parentResource = resourcesMapper.selectById(pid);
 
@@ -118,13 +121,6 @@ public Result createDirectory(User loginUser,
  }
  }
 
-
- if (checkResourceExists(fullName, 0, type.ordinal())) {
- logger.error("resource directory {} has exist, can't recreate", fullName);
- putMsg(result, Status.RESOURCE_EXIST);
- return result;
- }
-
  Date now = new Date();
 
  Resource resource = new Resource(pid,name,fullName,true,description,name,loginUser.getId(),type,0,now,now);

dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/ResourcesServiceTest.java

@@ -138,6 +138,10 @@ public void testCreateDirecotry(){
  Assert.assertEquals(Status.HDFS_NOT_STARTUP.getMsg(),result.getMsg());
 
  //PARENT_RESOURCE_NOT_EXIST
+ user.setId(1);
+ user.setTenantId(1);
+ Mockito.when(userMapper.selectById(1)).thenReturn(getUser());
+ Mockito.when(tenantMapper.queryById(1)).thenReturn(getTenant());
  PowerMockito.when(PropertyUtils.getResUploadStartupState()).thenReturn(true);
  Mockito.when(resourcesMapper.selectById(Mockito.anyInt())).thenReturn(null);
  result = resourcesService.createDirectory(user,"directoryTest","directory test",ResourceType.FILE,1,"/");