Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][CI] CI of unmerged PRs should rerun if a new PR gets merged #14412

Closed
3 tasks done
EricGao888 opened this issue Jun 27, 2023 · 2 comments · Fixed by #14530
Closed
3 tasks done

[Improvement][CI] CI of unmerged PRs should rerun if a new PR gets merged #14412

EricGao888 opened this issue Jun 27, 2023 · 2 comments · Fixed by #14530
Assignees
Labels
discussion discussion improvement make more easy to user or prompt friendly priority:high
Milestone

Comments

@EricGao888
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Suppose we have two PR A and B. A or B could pass CI but A and B together cause bugs and fail CI.

If the CI of A and B both had passed on 8 a.m. and A got merged on 9 a.m., in current settings, CI of B still looked good and could be merged. As a result, A and B together cause new bugs and PRs after them will fail the CI.

Therefore, we need to force the CI of unmerged PRs to rerun once a new PR gets merged.

Personally I have seen this kind of bugs happen in DS repo several times.

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@EricGao888 EricGao888 added improvement make more easy to user or prompt friendly priority:high labels Jun 27, 2023
@EricGao888 EricGao888 added this to the 3.2.0 milestone Jun 27, 2023
@EricGao888 EricGao888 self-assigned this Jun 27, 2023
@EricGao888 EricGao888 added the discussion discussion label Jun 27, 2023
@EricGao888
Copy link
Member Author

BTW, this issue may happen during we release a new version, which is highly risky.

@zhongjiajie
Copy link
Member

We can do that by turn on update to date for each PR ref https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/keeping-your-pull-request-in-sync-with-the-base-branch but it will take our maintainer much time and ci workflow more crowded

zhongjiajie added a commit to zhongjiajie/dolphinscheduler that referenced this issue Jul 13, 2023
IT-Kwj pushed a commit to IT-Kwj/dolphinscheduler that referenced this issue Jul 14, 2023
zhongjiajie added a commit that referenced this issue Jul 20, 2023
biaoma-ty pushed a commit to Kasma-Inc/dolphinscheduler that referenced this issue Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion discussion improvement make more easy to user or prompt friendly priority:high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants