Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI/CD]Write notes about ci/cd in contributing documentation #1464

Closed
khadgarmage opened this issue Dec 12, 2019 · 1 comment
Closed

[CI/CD]Write notes about ci/cd in contributing documentation #1464

khadgarmage opened this issue Dec 12, 2019 · 1 comment
Labels
feature new feature

Comments

@khadgarmage
Copy link
Contributor

follow the root issue: #1460
Content:

  • The new PR code ut coverage is required to reach 60%
  • The the coverage rate after merge PR can only be increased, not reduced
  • UT only use junit and mockito, we worried about license issues after other library is introduced
  • Before submitting the PR, you must ensure that the build passes, the ut passes, the license check、spotbugs check、checkstyle check、and eslint check all pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CalvinKirs @khadgarmage