Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/CD]Root issue to track #1460

Closed
khadgarmage opened this issue Dec 12, 2019 · 2 comments
Closed

[CI/CD]Root issue to track #1460

khadgarmage opened this issue Dec 12, 2019 · 2 comments
Labels
feature new feature

Comments

@khadgarmage
Copy link
Contributor

khadgarmage commented Dec 12, 2019

This is a root issue for CI/CD, if you want to learn about the detail, you can track the email link https://lists.apache.org/thread.html/00dffebaf5f62672cc0d67ffc8317bb531f66f14dcb8decf913cbbb8%40%3Cdev.dolphinscheduler.apache.org%3E

So far, no one has objected to the UT coverage rate, so we will implement it according to the 60% UT coverage rate.
When pmc or committer merge pr, pay attention to the codecov comments. We must ensure that the UT coverage rate
of the submitted PR files reach 60%, and it is guaranteed that the UT coverage rate will only increase after the PR is merged.

And this is a root issue for track the ci/cd process.

I will break it into many scattered issues for everyone to contribute under the root issue:

  • ut
  • checkstyle check
  • spotbugs check
  • Front-end eslint check
  • The CI / CD inspection and requirements are written into the code contribution document,
    the new PR code ut coverage is required to reach 60%, and the coverage can only be increased, not reduced.
  • We use codecov tool to replace coveralls tool in fact, and this job is done.
@davidzollo
Copy link
Contributor

thanks khadgarmage do this. welcome everyone who interesting in please join us

@CalvinKirs
Copy link
Member

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature
Projects
None yet
Development

No branches or pull requests

3 participants