Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/CD]Add checkstyle check #1461

Closed
khadgarmage opened this issue Dec 12, 2019 · 7 comments
Closed

[CI/CD]Add checkstyle check #1461

khadgarmage opened this issue Dec 12, 2019 · 7 comments
Labels
feature new feature

Comments

@khadgarmage
Copy link
Contributor

khadgarmage commented Dec 12, 2019

follow the root issue: #1460
Steps:
1、chose the checkstyle guidline, google or alibaba
2、modify files which not satisfy the guildline,and pay attention not to submit too much files each time in a pr, it is better not to exceed 10, which is convenient for review, and can be split into multiple pr to submit, and the pr which you submit should follow this issue (e.g. #1461).
3、Add to github action to execute this check in ".github" directory, and we must ensure that CI / CD is successfully rebuilt, you can put the files which you modified into the maven pom.xml whitelist, to ensure the rebuilt successfully.

@khadgarmage khadgarmage added the feature new feature label Dec 12, 2019
@nauu
Copy link
Contributor

nauu commented Dec 12, 2019

Let's start.

@nauu
Copy link
Contributor

nauu commented Dec 13, 2019

Which rule to use ? @khadgarmage

@khadgarmage
Copy link
Contributor Author

@nauu if you what to implement it, you can start a vote ^_^

@nauu
Copy link
Contributor

nauu commented Dec 13, 2019

+1

@khadgarmage
Copy link
Contributor Author

+1

oh, sorry, i find @lamber-ken had start to this job some days ago, you can chose other issue? ^_^

@khadgarmage
Copy link
Contributor Author

@lamber-ken hi, ppmc suggest we should use alibaba checkstyle.

@CalvinKirs
Copy link
Member

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature
Projects
None yet
Development

No branches or pull requests

3 participants