Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSIP-2][Doc] Refactor the document #6535

Open
27 of 70 tasks
Tracked by #14102
zhongjiajie opened this issue Oct 14, 2021 · 30 comments
Open
27 of 70 tasks
Tracked by #14102

[DSIP-2][Doc] Refactor the document #6535

zhongjiajie opened this issue Oct 14, 2021 · 30 comments
Labels
document DSIP good first issue good first issue good idea help wanted Extra attention is needed

Comments

@zhongjiajie
Copy link
Member

zhongjiajie commented Oct 14, 2021

Description

For now, we documentation is not easy enough to read and maintain. I think documentation is also an important for OSS, it would be

General

Content

DRY

  • remove duplicate content in the document, for example in installation we have duplicate download mysql dependent
  • Many parameters of task have same definition, find a way to handle it. maybe we could see what github/doc do, https://github.com/github/docs

Missing document

To be classify

To be update

Syntax

  • Use markdown table syntax instead of html table syntax <table>
  • Find a better way to show our picture, for now it use html syntax in markdown file. I find our it can be show use markdown image syntax, such as this line

CI

@github-actions
Copy link

Hi:

@zhongjiajie
Copy link
Member Author

Hi @lukairui, I assigned ambari integration to your now.

@lukairui
Copy link

Hi @lukairui, I assigned ambari integration to your now.

Done,please review my pr.

@davidzollo
Copy link
Contributor

Do you have any suggestions about Docs? please leave message

@davidzollo
Copy link
Contributor

davidzollo commented Dec 2, 2021

I suggest to add doc about how to use open API
it will be better if there are many parameters examples about each API interface

@zhongjiajie
Copy link
Member Author

I suggest to add doc about how to use open API it will be better if there are many parameters examples about each API interface

Yeah, I think so. but I think we should find some way to auto-generate from our codebase instead of directly write doc by hand

@linjicong
Copy link

I noticed that some pictures are blurred

@zhongjiajie
Copy link
Member Author

I noticed that some pictures are blurred

@linjicong Do you interested in this issue? I could create a new issue and assign to you if you like to do that.

@JinsYin
Copy link
Contributor

JinsYin commented Dec 21, 2021

We should also improve the document comments in the code, then use it in the website.

@zhongjiajie
Copy link
Member Author

We should also improve the document comments in the code, then use it in the website.

You’re right do you have any idea to do it? Or you want to submit some PR to fix this?

@zhongjiajie
Copy link
Member Author

zhongjiajie commented Jan 6, 2022

The reason why we think the document is important, but why our community seems do not pay more attention on it

@Lucaszlei
Copy link
Contributor

@zhongjiajie I am interested and able to help with the construction and improvement of the document. Next, I will gradually complete some of the problems mentioned above.

@zhongjiajie
Copy link
Member Author

Hi, @sunnyz-l Thanks for play attention to the DolphinScheduler documents, looking forward to your contributions and you could ping me if you have any problems.

@linjicong
Copy link

@zhongjiajie
Is the file About_DolphinScheduler/About_DolphinScheduler.md standalone non-version module? This page now display 404 error when change language.

@zhongjiajie
Copy link
Member Author

@zhongjiajie
Is the file About_DolphinScheduler/About_DolphinScheduler.md standalone non-version module? This page now display 404 error when change language.

Yeah, I check and you're right, it seems we have error in our introduction section. Do you want to correct it @linjicong

@linjicong
Copy link

@zhongjiajie
Is the file About_DolphinScheduler/About_DolphinScheduler.md standalone non-version module? This page now display 404 error when change language.

Yeah, I check and you're right, it seems we have error in our introduction section. Do you want to correct it @linjicong

I just submit a PR for it.

@zhongjiajie
Copy link
Member Author

I add some independent new tasks for our tasks type usage. in #6535 (comment). You could search with the keyword "Task Usage" If anyone who interested in it, just feel free to take it and ping me in this issue.

@zhongjiajie
Copy link
Member Author

zhongjiajie commented Jan 14, 2022

I just submit a PR for it.

Thanks and I already review and left some commet in your PR @linjicong

@jj551
Copy link

jj551 commented Jan 18, 2022

@zhongjiajie architecture ! hi brother

@zhongjiajie
Copy link
Member Author

zhongjiajie commented Jan 18, 2022

architecture ! hi brother

@Kodalien I found out architecture has two children issue. which do you like to do?

  1. Task queue. questions on architecture-design.md of 1.3.9 questions on architecture-design.md of 1.3.9 #7835
  2. Architecture diagram. it seems that architecture diagram in the official website didn't update correspondingly it seems that architecture diagram in the official website didn't update correspondingly #7306

@jj551
Copy link

jj551 commented Jan 19, 2022

Hi,brother@zhongjiajie have alreadly done,but I think new architecture needs to develop to demo in modification

@zhongjiajie
Copy link
Member Author

Hi,brother@zhongjiajie have alreadly done,but I think new architecture needs to develop to demo in modification

Hi @Kodalien which part should add, could you tell more detail about it.

@jj551
Copy link

jj551 commented Jan 19, 2022

need 2.0 architecture diagram demo @zhongjiajie

@zhongjiajie
Copy link
Member Author

need 2.0 architecture diagram demo @zhongjiajie

I got your point, @caishunfeng do you have time to update our architecture diagram?

@caishunfeng
Copy link
Contributor

need 2.0 architecture diagram demo @zhongjiajie

I got your point, @caishunfeng do you have time to update our architecture diagram?

The architecture diagram in the document still applies to version 2.0.

@zhongjiajie
Copy link
Member Author

need 2.0 architecture diagram demo @zhongjiajie

I got your point, @caishunfeng do you have time to update our architecture diagram?

The architecture diagram in the document still applies to version 2.0.

Thanks @caishunfeng for clarifications, cc @Kodalien it seem we could keep it in, WDYT

@QuakeWang
Copy link
Contributor

Hi, I will do this task, please assign to me : )

@zhongjiajie
Copy link
Member Author

Hi, I will do this task, please assign to me : )

Hi @QuakeWang, thanks for you attend to this issue. but it is a collection of some known document tasks, you should point out which sub issue in #6535 (comment) you are interesting in instead of whole issue

@QuakeWang
Copy link
Contributor

Hi, I will do this task, please assign to me : )

Hi @QuakeWang, thanks for you attend to this issue. but it is a collection of some known document tasks, you should point out which sub issue in #6535 (comment) you are interesting in instead of whole issue

OK, I will leave a comment under the specific issue.

@EricGao888
Copy link
Member

We need to consistently improve the quality of our docs, especially English docs, see: #11385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document DSIP good first issue good first issue good idea help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests