Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DSIP-11][python] create workflows from YAML configuration #11611

Merged
merged 2 commits into from
Sep 6, 2022
Merged

[DSIP-11][python] create workflows from YAML configuration #11611

merged 2 commits into from
Sep 6, 2022

Conversation

jieguangzhou
Copy link
Member

@jieguangzhou jieguangzhou commented Aug 23, 2022 •
edited
Loading

Purpose of the pull request

close: #10995

Brief change log

  • YAML parse module
  • YAML task examples
  • CLI
  • Document

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@jieguangzhou jieguangzhou changed the title [DSIP-11][Feature][python] Use the pydolphinscheduler to dynamically generate workflows from the configuration file [Draft][DSIP-11][Feature][python] Use the pydolphinscheduler to dynamically generate workflows from the configuration file Aug 23, 2022
@jieguangzhou jieguangzhou marked this pull request as draft August 23, 2022 10:36
@SbloodyS SbloodyS added the feature new feature label Aug 24, 2022
@SbloodyS SbloodyS added this to the 3.1.0 milestone Aug 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2022 •
edited
Loading

Codecov Report

Merging #11611 (b84b33a) into dev (23d8aaf) will decrease coverage by 0.20%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #11611      +/-   ##
============================================
- Coverage     39.80%   39.59%   -0.21%     
+ Complexity     4716     4690      -26     
============================================
  Files          1002     1014      +12     
  Lines         37872    37936      +64     
  Branches       4230     4244      +14     
============================================
- Hits          15074    15020      -54     
- Misses        21195    21309     +114     
- Partials       1603     1607       +4
Impacted Files Coverage Δ
...r/server/worker/registry/WorkerRegistryClient.java 46.66% <0.00%> (-27.41%) ⬇️
...dolphinscheduler/service/log/LogClientService.java 63.85% <0.00%> (-12.96%) ⬇️
...r/server/master/registry/MasterRegistryClient.java 38.46% <0.00%> (-4.01%) ⬇️
...inscheduler/server/log/LoggerRequestProcessor.java 17.30% <0.00%> (-1.85%) ⬇️
...nscheduler/service/process/ProcessServiceImpl.java 31.67% <0.00%> (-0.12%) ⬇️
...phinscheduler/service/registry/RegistryClient.java 0.91% <0.00%> (-0.08%) ⬇️
.../org/apache/dolphinscheduler/api/enums/Status.java 100.00% <0.00%> (ø)
...che/dolphinscheduler/api/python/PythonGateway.java 17.82% <0.00%> (ø)
...pache/dolphinscheduler/common/utils/JSONUtils.java 69.79% <0.00%> (ø)
...e/dolphinscheduler/dao/entity/ProcessInstance.java 0.00% <0.00%> (ø)
... and 55 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

63.8% 63.8% Coverage
0.0% 0.0% Duplication

@jieguangzhou jieguangzhou marked this pull request as ready for review August 26, 2022 08:59
@jieguangzhou
Copy link
Member Author

@zhongjiajie PTAL, thanks

@jieguangzhou jieguangzhou changed the title [Draft][DSIP-11][Feature][python] Use the pydolphinscheduler to dynamically generate workflows from the configuration file [DSIP-11][Feature][python] Use the pydolphinscheduler to dynamically generate workflows from the configuration file Aug 27, 2022
zhongjiajie
zhongjiajie reviewed Aug 27, 2022
View reviewed changes
dolphinscheduler-python/pydolphinscheduler/tests/core/test_yaml_process_define.py Outdated Show resolved Hide resolved
dolphinscheduler-python/pydolphinscheduler/src/pydolphinscheduler/core/yaml_process_define.py Outdated Show resolved Hide resolved
dolphinscheduler-python/pydolphinscheduler/src/pydolphinscheduler/core/yaml_process_define.py Outdated Show resolved Hide resolved
dolphinscheduler-python/pydolphinscheduler/src/pydolphinscheduler/core/yaml_process_define.py Outdated Show resolved Hide resolved
dolphinscheduler-python/pydolphinscheduler/src/pydolphinscheduler/core/yaml_process_define.py Outdated Show resolved Hide resolved
dolphinscheduler-python/pydolphinscheduler/tests/core/test_yaml_process_define.py Outdated Show resolved Hide resolved
dolphinscheduler-python/pydolphinscheduler/tests/core/test_yaml_process_define.py Show resolved Hide resolved
@jieguangzhou
Copy link
Member Author

@zhongjiajie PTAL, thanks

@jieguangzhou
Copy link
Member Author

@zhongjiajie PTAL, thanks

@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2022

Please retry analysis of this Pull-Request directly on SonarCloud.

zhongjiajie
zhongjiajie approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@zhongjiajie zhongjiajie merged commit 38ee91f into apache:dev Sep 6, 2022
@zhongjiajie zhongjiajie changed the title [DSIP-11][Feature][python] Use the pydolphinscheduler to dynamically generate workflows from the configuration file [DSIP-11][python] create workflows from YAML configuration Sep 6, 2022
fengjian1129 pushed a commit to fengjian1129/dolphinscheduler that referenced this pull request Sep 13, 2022
@jieguangzhou
[DSIP-11][python] create workflows from YAML configuration (apache#11611
c3d74d6 
)
jieguangzhou added a commit to jieguangzhou/dolphinscheduler that referenced this pull request Sep 16, 2022
@jieguangzhou
[DSIP-11][python] create workflows from YAML configuration (apache#11611
0033956 
)

(cherry picked from commit 38ee91f)
@jieguangzhou jieguangzhou mentioned this pull request Sep 16, 2022
Merged
caishunfeng pushed a commit that referenced this pull request Sep 17, 2022
@jieguangzhou
[3.1.0-prepare][cherry-pick][DSIP-11][python] create workflows from Y…
5e42f52 
…AML configuration (#11988)

* [DSIP-11][python] create workflows from YAML configuration (#11611)

(cherry picked from commit 38ee91f)

* fix pydolphin yaml doc link (#11817)

(cherry picked from commit c41fa5a)
@caishunfeng caishunfeng added the release cherry-pick Mark this issue/PR had cherry-pick for release version label Sep 19, 2022
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 13, 2022
@jieguangzhou @xdu-chenrj
[DSIP-11][python] create workflows from YAML configuration (apache#11611
e118359 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricGao888 EricGao888 EricGao888 left review comments

@zhongjiajie zhongjiajie zhongjiajie approved these changes

Assignees

@jieguangzhou jieguangzhou

Labels
document feature new feature Python release cherry-pick Mark this issue/PR had cherry-pick for release version
Projects
None yet
Milestone
3.1.0
6 participants
@jieguangzhou @codecov-commenter @zhongjiajie @EricGao888 @caishunfeng @SbloodyS