Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] should notice that need setting the full path when call the resource file #11620 #11621

Merged
merged 2 commits into from
Aug 26, 2022

Conversation

DarkAssassinator
Copy link
Contributor

Purpose of the pull request

fix #11620

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Aug 23, 2022
@SbloodyS SbloodyS added this to the 3.0.1 milestone Aug 23, 2022
Copy link
Member

@EricGao888 EricGao888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, except few nits.

docs/docs/en/guide/project/workflow-definition.md Outdated Show resolved Hide resolved
docs/docs/en/guide/resource/file-manage.md Outdated Show resolved Hide resolved
docs/docs/en/guide/resource/file-manage.md Outdated Show resolved Hide resolved
docs/docs/zh/guide/project/workflow-definition.md Outdated Show resolved Hide resolved
@DarkAssassinator
Copy link
Contributor Author

done. Please review again. thx

@EricGao888
Copy link
Member

done. Please review again. thx

LGTM, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document improvement make more easy to user or prompt friendly release cherry-pick Mark this issue/PR had cherry-pick for release version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] should notice that need setting the full path when call the resource file
4 participants