Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [Master] fix State event handle error, get a unknown exception, will retry this event with IndexOutOfBoundsException #14361

Merged
merged 3 commits into from
Jun 19, 2023

Conversation

lxorc
Copy link
Contributor

@lxorc lxorc commented Jun 16, 2023

Purpose of the pull request

fix #14360

Brief change log

  • fix complementListDate IndexOutOfBoundsException

Verify this pull request

This pull request is code cleanup without any test coverage.

@SbloodyS SbloodyS added bug Something isn't working 3.2.0 for 3.2.0 version labels Jun 16, 2023
@SbloodyS SbloodyS added this to the 3.2.0 milestone Jun 16, 2023
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link this PR to your issue.

@lxorc
Copy link
Contributor Author

lxorc commented Jun 16, 2023

Please link this PR to your issue.

done

@lxorc lxorc changed the title fix State event handle error, get a unknown exception, will retry this event with IndexOutOfBoundsException #14360 fix State event handle error, get a unknown exception, will retry this event with IndexOutOfBoundsException Jun 16, 2023
@lxorc lxorc changed the title fix State event handle error, get a unknown exception, will retry this event with IndexOutOfBoundsException [Bug] [Master] State event handle error, get a unknown exception, will retry this event with IndexOutOfBoundsException Jun 16, 2023
@lxorc lxorc changed the title [Bug] [Master] State event handle error, get a unknown exception, will retry this event with IndexOutOfBoundsException [Bug] [Master] fix State event handle error, get a unknown exception, will retry this event with IndexOutOfBoundsException Jun 16, 2023
@SbloodyS SbloodyS added 3.1.x for 3.1.x version and removed 3.2.0 for 3.2.0 version labels Jun 16, 2023
@SbloodyS SbloodyS modified the milestones: 3.2.0, 3.1.8 Jun 16, 2023
…ler/server/master/runner/WorkflowExecuteRunnable.java

Co-authored-by: Wenjun Ruan <wenjun@apache.org>
…ler/server/master/runner/WorkflowExecuteRunnable.java

Co-authored-by: Aaron Wang <wangweirao16@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2023

Codecov Report

Merging #14361 (99a1d50) into dev (f840b17) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 99a1d50 differs from pull request most recent head 3db2a80. Consider uploading reports for the commit 3db2a80 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14361      +/-   ##
============================================
- Coverage     38.49%   38.49%   -0.01%     
- Complexity     4560     4563       +3     
============================================
  Files          1237     1237              
  Lines         43538    43541       +3     
  Branches       4814     4813       -1     
============================================
- Hits          16761    16760       -1     
- Misses        24922    24929       +7     
+ Partials       1855     1852       -3     
Impacted Files Coverage Δ
.../server/master/runner/WorkflowExecuteRunnable.java 10.62% <0.00%> (-0.03%) ⬇️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Jun 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ruanwenjun ruanwenjun merged commit 5cbe170 into apache:dev Jun 19, 2023
45 checks passed
zhongjiajie pushed a commit that referenced this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.1.x for 3.1.x version backend bug Something isn't working
Projects
None yet
6 participants