Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement-14395][UI] Description input box can not input blank #14396

Merged
merged 1 commit into from
Jun 28, 2023
Merged

[Improvement-14395][UI] Description input box can not input blank #14396

merged 1 commit into from
Jun 28, 2023

Conversation

Radeity
Copy link
Member

@Radeity Radeity commented Jun 21, 2023

Purpose of the pull request

Brief change log

  • Remove trim restriction for input box.

Verify this pull request

image

@Radeity Radeity requested a review from songjianet as a code owner June 21, 2023 16:21
@github-actions github-actions bot added the UI ui and front end related label Jun 21, 2023
@Radeity Radeity added the improvement make more easy to user or prompt friendly label Jun 21, 2023
@Radeity Radeity self-assigned this Jun 21, 2023
@Radeity Radeity changed the title [Improvement][UI] Description input box can not input blank [Improvement-14395][UI] Description input box can not input blank Jun 21, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

songjianet
songjianet reviewed Jun 26, 2023
View reviewed changes
Copy link
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you delete this, it seems that you can also enter spaces on the left and right.

@Radeity
Copy link
Member Author

Radeity commented Jun 26, 2023

If you delete this, it seems that you can also enter spaces on the left and right.

Do you mean we should trim it in backend?

@songjianet
Copy link
Member

If you delete this, it seems that you can also enter spaces on the left and right.

Do you mean we should trim it in backend?

/src/utils/trim.ts You may need to modify this method to allow spaces in between, but not before and after.

@songjianet songjianet added this to the 3.2.0 milestone Jun 28, 2023
@songjianet songjianet added the 3.2.0 for 3.2.0 version label Jun 28, 2023
@songjianet songjianet merged commit 8a2c05f into apache:dev Jun 28, 2023
47 checks passed
@Radeity Radeity deleted the Improvement-14395 branch June 28, 2023 08:58
IT-Kwj pushed a commit to IT-Kwj/dolphinscheduler that referenced this pull request Jul 14, 2023
@Radeity
[Improvement][UI] Description input box can not input blank (apache#1…
d304f8d 
…4396)
zhongjiajie pushed a commit that referenced this pull request Jul 20, 2023
@Radeity @zhongjiajie
[Improvement][UI] Description input box can not input blank (#14396)
d1026bc 
(cherry picked from commit 8a2c05f)
biaoma-ty pushed a commit to Kasma-Inc/dolphinscheduler that referenced this pull request Aug 17, 2023
@Radeity @biaoma-ty
[Improvement][UI] Description input box can not input blank (apache#1…
bc4aae0 
…4396)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songjianet songjianet songjianet approved these changes

Assignees

@Radeity Radeity

Labels
3.2.0 for 3.2.0 version improvement make more easy to user or prompt friendly UI ui and front end related
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

[Improvement][UI] Description input box can not input blank
2 participants
@Radeity @songjianet