-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix-14397][dao] the task node in the imported workflow definition was not displayed on the task definition page #14398
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution :D
Codecov Report
@@ Coverage Diff @@
## dev #14398 +/- ##
=========================================
Coverage 38.55% 38.56%
+ Complexity 4559 4556 -3
=========================================
Files 1236 1236
Lines 43451 43452 +1
Branches 4810 4812 +2
=========================================
+ Hits 16754 16756 +2
+ Misses 24839 24838 -1
Partials 1858 1858
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase the latest dev branch.
hi @penggeyuanlishe are you still there, could you please rebase the dev code to pass the CI? |
ok |
Kudos, SonarCloud Quality Gate passed! |
|
my pleasure ! |
@rickchengx Hi next time merging the pr, please notice the pr title, currently is Chinese now |
Sure, my mistake |
…4397 (apache#14398) Co-authored-by: huangjp@zetyun.com <huangjp@zetyun.com>
…4397 (apache#14398) Co-authored-by: huangjp@zetyun.com <huangjp@zetyun.com>
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md