[Feature] Improve user experience in datasource page #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To improve user experience in datasource page, add default port for each type database.
1. When create or edit datasource, there is a default vaule for port. If user changes type, the default value changes.
2. Use local variables in browser memory, to cache user previous input port for each type. For example :
time-a: MySQL default port is 3306 , user change 3306 to 4000.
time-b: User change type from MySQL to ClickHouse , the port change from 4000 to 8123.
time-c: User change type from ClickHouse back to MySQL，the port change from 8123 to 4000，use previous input cache to fillback.
3. In edit datasource page, when the page first loads, use the query value fillback instead of default value.
Codecov Report
@@ Coverage Diff @@
## dev #1471 +/- ##
=====================================
Coverage 0.22% 0.22%
=====================================
Files 271 271
Lines 13591 13591
Branches 2158 2158
=====================================
Hits 31 31
Misses 13550 13550
Partials 10 10Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
For #1470 .
To improve user experience in datasource page, add default port for each type database.
When create or edit datasource, there is a default vaule for port. If user changes type, the default value changes.
Use local variables in browser memory, to cache user previous input port for each type. For example :
time-a: MySQL default port is 3306 , user change 3306 to 4000.
time-b: User change type from MySQL to ClickHouse , the port change from 4000 to 8123.
time-c: User change type from ClickHouse back to MySQL，the port change from 8123 to 4000，use previous input cache to fillback.
In edit datasource page, when the page first loads, use the query value fillback instead of default value.
Brief change log
Verify this pull request