fix AbstractTask's handle method exception #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1490 +/- ##
========================================
+ Coverage 2.69% 2.7% +<.01%
========================================
Files 271 271
Lines 13593 13589 -4
Branches 2159 2157 -2
========================================
Hits 367 367
+ Misses 13209 13205 -4
Partials 17 17
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
This pull request is mainly fix the bug of AbstractTask class;
when the task is executed by TaskScheduleThread, task.handle () will be called to trigger the execution logic of the task itself. If the task throw a exception, it will capture and call the kill () method to kill the task and set the task status to failed
However, when each task subclass overrides the handle () method, it chooses to catch the exception itself and print the error log without throwing it.
This will cause the TaskScheduleThread thread to execute task but can't catch the task exception forever. The logic of killing the task cannot be triggered forever, and the completion status of the task may not be set correctly.
Brief change log
add throw e to subclass of AbstractTask
Verify this pull request
This pull request is bug fix without any test coverage.