Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu arrow style fix #1531

Merged
merged 20 commits into from
Dec 20, 2019
Merged

Menu arrow style fix #1531

merged 20 commits into from
Dec 20, 2019

Conversation

break60
Copy link
Contributor

@break60 break60 commented Dec 20, 2019

Tips

What is the purpose of the pull request

(For example: This pull request adds checkstyle plugin.)

Brief change log

(for example:)

  • Add maven-checkstyle-plugin to root pom.xml

Verify this pull request

(Please pick either of the following options)

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added dolphinscheduler-dao tests for end-to-end.
  • Added CronUtilsTest to verify the change.
  • Manually verified the change by testing locally.

@codecov-io
Copy link

Codecov Report

Merging #1531 into dev will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             dev   #1531      +/-   ##
========================================
- Coverage   6.98%   6.97%   -0.02%     
========================================
  Files        272     272              
  Lines      13622   13622              
  Branches    2168    2168              
========================================
- Hits         952     950       -2     
- Misses     12603   12605       +2     
  Partials      67      67
Impacted Files Coverage Δ
...ache/dolphinscheduler/common/enums/ZKNodeType.java 0% <0%> (-100%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d00463...f01dc30. Read the comment docs.

Copy link
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants