-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement][API]Enhance mysql connection properties #15433
Conversation
tests error, could you please fix it? |
...java/org/apache/dolphinscheduler/plugin/datasource/mysql/param/MySQLDataSourceProcessor.java
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #15433 +/- ##
============================================
- Coverage 38.11% 38.11% -0.01%
- Complexity 4696 4697 +1
============================================
Files 1299 1299
Lines 44773 44774 +1
Branches 4798 4797 -1
============================================
Hits 17066 17066
- Misses 25858 25861 +3
+ Partials 1849 1847 -2 ☔ View full report in Codecov by Sentry. |
Yes,has fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
@zhongjiajie sir, sorry to disturb you but i am waiting for your approval and response in HTTP task parameter issue also I have tried to contact you via email. |
|
Purpose of the pull request
This pull request enhance mysql connection properties
Brief change log