[DSIP-66][k8s] Support User-customized K8s YAML Pod #16477
+1,629
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mighten
requested review from
EricGao888,
SbloodyS,
songjianet,
Amy0104,
caishunfeng,
zhuangchong,
Gallardot and
ruanwenjun
as code owners
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md) |
Mighten
changed the title
|
First you need to create a DSIP. |
Gallardot
added
discussion
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/k8s/AbstractK8sOperation.java
Fixed
Show fixed
Hide fixed
...-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/k8s/AbstractK8sOperation.java
Fixed
Show fixed
Hide fixed
Yes you need to create a DSIP, and provide detailed design, rather then directly submit a PR. |
|
@Mighten Please modify the associated issue number |
Mighten
changed the title
Mighten
changed the title
* Added `YamlUtils` with `jackson-dataformat-yaml`(new dependency in `pom.xml`)* * Updated `K8sUtils` with default namespace injection* * Added user-customized YAML task mode, with frontend and backend*
Mighten
changed the title
songjianet
approved these changes
Aug 20, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
This pull request adds user-customized YAML support for Kubernetes Pod task,
and aims to close: #16482
Brief change log
YamlUtilswithjackson-dataformat-yaml(new dependency inpom.xml)K8sUtilswith default namespace injectionVerify this pull request
This change added tests and can be verified as follows:
Added
YamlUtilsTestto verifyYamlUtilsAdded
K8sUtilsTestto verify updates forK8sUtilsManually verified the user-customized YAML task mode using both the web page and IDE output:
Switch on the Custom Template mode, and paste Kubernetes YAML file content:
Conclusion: The user-customized YAML mode works correctly in the frontend.
Online, Start the current workflow and review the log of the current task instance:
Conclusion: The user-customized YAML mode works correctly in the backend.
Review the pod output parameters parsed from the log in the IDE console (these are not listed in the task instance log window):
Conclusion: The user-customized YAML mode correctly parses the output values from the log.