[DSIP-67] Use command to trigger workflow instance rather generate workflow instance #16523
+1,826
−1,312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
requested review from
caishunfeng,
SbloodyS,
songjianet,
Amy0104 and
Gallardot
as code owners
ruanwenjun
force-pushed
the
dev_wenjun_moveGenerateWorkflowInstance2Master
branch
from
75d8821
to
cf8ba93
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| private void doBackfillDependentWorkflow(final BackfillWorkflowCommandParam backfillWorkflowCommandParam, | ||
| final Command backfillCommand) { | ||
| private void doBackfillDependentWorkflow(final BackfillWorkflowDTO backfillWorkflowDTO, |
Check notice
Code scanning / CodeQL
Useless parameter Note
| private void doBackfillDependentWorkflow(final BackfillWorkflowCommandParam backfillWorkflowCommandParam, | ||
| final Command backfillCommand) { | ||
| private void doBackfillDependentWorkflow(final BackfillWorkflowDTO backfillWorkflowDTO, | ||
| final List<String> backfillTimeList) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
SbloodyS
reviewed
Aug 27, 2024
ruanwenjun
force-pushed
the
dev_wenjun_moveGenerateWorkflowInstance2Master
branch
3 times, most recently
from
43b6bd0
to
244b7f2
Compare
ruanwenjun
force-pushed
the
dev_wenjun_moveGenerateWorkflowInstance2Master
branch
from
244b7f2
to
6a3505f
Compare
ruanwenjun
force-pushed
the
dev_wenjun_moveGenerateWorkflowInstance2Master
branch
from
6a3505f
to
b9d4032
Compare
ruanwenjun
force-pushed
the
dev_wenjun_moveGenerateWorkflowInstance2Master
branch
from
b9d4032
to
5674832
Compare
ruanwenjun
force-pushed
the
dev_wenjun_moveGenerateWorkflowInstance2Master
branch
from
5674832
to
8fec4a4
Compare
|
SbloodyS
approved these changes
Aug 28, 2024
3 tasks
|
Will this PR merge into section 3.1.9？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #16485
Brief change log
TriggerRelation, since we can directly use workflow instance id to track workflow instance.Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md