[Improvement-16527][alert] Add retry send email validAddresses when abnormal addresses in the email receiving list #16529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SbloodyS
added
bug
SbloodyS
reviewed
Aug 27, 2024
...ler-alert-email/src/main/java/org/apache/dolphinscheduler/plugin/alert/email/MailSender.java
Outdated
Show resolved
Hide resolved
...ler-alert-email/src/main/java/org/apache/dolphinscheduler/plugin/alert/email/MailSender.java
Outdated
Show resolved
Hide resolved
SbloodyS
reviewed
Aug 28, 2024
...ler-alert-email/src/main/java/org/apache/dolphinscheduler/plugin/alert/email/MailSender.java
Show resolved
Hide resolved
SbloodyS
reviewed
Aug 30, 2024
Comment on lines
+166
to
+174
| @Test | ||
| public void testReceiversWithInvalidAddress() { | ||
| String content = list2String(); | ||
| emailConfig.put(AlertConstants.NAME_SHOW_TYPE, ShowType.TABLE_ATTACHMENT.getDescp()); | ||
| emailConfig.put(MailParamsConstants.NAME_PLUGIN_DEFAULT_EMAIL_RECEIVERS, "347801120@qq.com,xxx@qq.com"); | ||
| mailSender = new MailSender(emailConfig); | ||
| AlertResult alertResult = mailSender.sendMails("gaojing", content); | ||
| Assertions.assertFalse(alertResult.isSuccess()); | ||
| } |
There was a problem hiding this comment.
For the bug you fix, you should test the input of, say, 3 email addresses, 2 of which are valid and 1 of which is invalid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
The content of this commit adjusts the email notification module so that when invalid email addresses are included among multiple recipients, it does not prevent all recipients from receiving emails. Instead, emails will continue to be delivered to the actual valid email addresses.
close #16527
Brief change log
Verify this pull request
This change added tests and can be verified as follows:
email alert to user whose email address is valid, and add other email address which is invalid ,when send email alert, the part of valid email address will receive the email alert message