[DSIP-27][Task Plugin] Some improvements of JAVA task plugin #16542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ailiujiarui
requested review from
songjianet,
Amy0104,
caishunfeng,
SbloodyS,
zhuangchong and
Gallardot
as code owners
SbloodyS
changed the title
SbloodyS
added
first time contributor
SbloodyS
changed the title
ailiujiarui
force-pushed
the
dev
branch
2 times, most recently
from
9c45ca0
to
6d16b63
Compare
ailiujiarui
force-pushed
the
dev
branch
3 times, most recently
from
37b92ed
to
151bdfe
Compare
SbloodyS
reviewed
Sep 3, 2024
Please check if additional explanation is needed
|
fuchanghai
reviewed
Sep 4, 2024
...ler-task-java/src/main/java/org/apache/dolphinscheduler/plugin/task/java/JavaParameters.java
Show resolved
Hide resolved
ailiujiarui
force-pushed
the
dev
branch
2 times, most recently
from
ac19f4f
to
81b47d9
Compare
|
Don't be discouraged. Keep going and keep up the good work. |
ailiujiarui
force-pushed
the
dev
branch
3 times, most recently
from
a26d766
to
29b9d50
Compare
I implemented a strategy where the source code is compiled and packaged into a JAR file during the application's runtime. This approach eliminates the necessity of mounting files within the image. |
SbloodyS
requested changes
Nov 1, 2024
...er-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/cases/WorkflowJavaTaskE2ETest.java
Outdated
Show resolved
Hide resolved
...er-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/cases/WorkflowJavaTaskE2ETest.java
Outdated
Show resolved
Hide resolved
...er-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/cases/WorkflowJavaTaskE2ETest.java
Outdated
Show resolved
Hide resolved
...er-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/cases/WorkflowJavaTaskE2ETest.java
Outdated
Show resolved
Hide resolved
...er-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/cases/WorkflowJavaTaskE2ETest.java
Outdated
Show resolved
Hide resolved
...er-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/cases/WorkflowJavaTaskE2ETest.java
Outdated
Show resolved
Hide resolved
...er-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/cases/WorkflowJavaTaskE2ETest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/apache/dolphinscheduler/e2e/pages/project/workflow/task/JavaTaskForm.java
Outdated
Show resolved
Hide resolved
dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/resources/common/Fat.java
Outdated
Show resolved
Hide resolved
...er-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/cases/WorkflowJavaTaskE2ETest.java
Outdated
Show resolved
Hide resolved
ailiujiarui
force-pushed
the
dev
branch
7 times, most recently
from
e8d5c62
to
b3ccfb9
Compare
|
Please retry analysis of this Pull-Request directly on SonarCloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Update the Java task plugin
close:#15819
Brief change log
Deprecate write java code in JAVA task
Rename the JAR to FATJAR
Only the displayed name has been modified, the functionality remains unchanged.
Add the new type NORMALJAR
Allow users to upload normal type of jar files, which require external libraries to run properly. Users do not need to package all libraries and runtime files into a fat jar each time, making the submission of jar files more flexible and convenient.
Update the tests
Update tests about JAVA type and add the test of JAR type. Like JavaTaskTest and workflowJavaTaskE2ETest.
For the JavaE2Etest, the fat.java,normal1.java,normal2.java,have been added e2e-case/resources/docker/java-task. These three Java files will be compiled and packaged into fat.jar, normal1.jar, and normal2.jar. fat.jar is for the FAT_JAR type. The normal1.jar and normal2.jar are for the NORMAL_JAR type.
Update the Javadoc comment
type of FATJAR
type of NORMALJAR
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md