[Improvement-16507] Remove spring-boot-starter-cache

[binitshrest]

I changed and removed the some extra dependencies that should be removed after removing spring-boot-starter-cache from pom.xml and application.properties file. That has caused the issues. After removing extra dependencies and the server runs smoothly with out any bugs

close #16507

[boring-cyborg]

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

[binitshrest]

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
Hi, Can you please review if i updated based on the given documentations.

[ruanwenjun]

We should remove the code and dependency of spring-boot-starter-cache.

[binitshrest]

We should remove the code and dependency of spring-boot-starter-cache.

Hi ruanwenjun,
After carefully observing and understanding the codebase. I have removed the extra dependency of the spring-boot-starter-cache which includes the related annotations like cacheable and cacheconfig. I removed it and the codebase runs without any issues. I am open for some more suggestions from your side. As spring-boot-starter-cache dependency has been removed from POM.xml and application.properties files. I went some more depth and removed some related annotations.

[binitshrest]

@caishunfeng Can you please guide me to fix 5 failing issues?

[SbloodyS]

You should check these two dependency. @binitshrest

log4j-api-2.17.2.jar
log4j-to-slf4j-2.17.2.jar

[binitshrest]

You should check these two dependency. @binitshrest

log4j-api-2.17.2.jar
log4j-to-slf4j-2.17.2.jar

log4j-to-slf4j-2.17.2.jar

Thank you SbloodyS. I found them. There are so many of these dependencies. Should i remove them too.

[binitshrest]

You should check these two dependency. @binitshrest

log4j-api-2.17.2.jar
log4j-to-slf4j-2.17.2.jar

log4j-to-slf4j-2.17.2.jar

Thank you @SbloodyS. I found them. There are so many of these dependencies. Should i remove them too.

[ruanwenjun]

@ruanwenjun sir. Did i solve this issue? Please let me know. I am encouraged that all the checks are passed.

@binitshrest Yes, the ci has passed. But there are some extra things need to do.

1. Please remove two license files

`dolphinscheduler-dist/release-docs/licenses/LICENSE-log4j-api-2.11.2.txt`
`dolphinscheduler-dist/release-docs/licenses/LICENSE-log4j-core-2.11.2.txt`

Since you have removed these from LICENSE, and we really don't rely on these, good job, you have solved a new problem.
2. I am not sure if we need to add exclusion in all place, I add comment. Since once we add these, it will be hard to remove in the future, my experience is we only need to exclude these in dependencymanagement. It's need to have a try.

[binitshrest]

@ruanwenjun sir. Did i solve this issue? Please let me know. I am encouraged that all the checks are passed.

@binitshrest Yes, the ci has passed. But there are some extra things need to do.

1. Please remove two license files

`dolphinscheduler-dist/release-docs/licenses/LICENSE-log4j-api-2.11.2.txt`
`dolphinscheduler-dist/release-docs/licenses/LICENSE-log4j-core-2.11.2.txt`

Since you have removed these from LICENSE, and we really don't rely on these, good job, you have solved a new problem. 2. I am not sure if we need to add exclusion in all place, I add comment. Since once we add these, it will be hard to remove in the future, my experience is we only need to exclude these in dependencymanagement. It's need to have a try.

Yes, Sir. We don't need to add that exclusion code in all place. I saw in this morning. Once i put that exclusion in root dependency. It will remove from all. I am not sure if i should remove from test scope . I will make also some changes what you have said earlier.

[binitshrest]

Please retry analysis of this Pull-Request directly on SonarCloud

Do i have to worry about this sir? @ruanwenjun

[ruanwenjun]

Please retry analysis of this Pull-Request directly on SonarCloud

Do i have to worry about this sir? @ruanwenjun

No, this is not related to your change, and will not block this PR.

[SbloodyS]

Generally LGTM. Just some NIT.

[SbloodyS]

Please avoid unnessnary chanage.

[SbloodyS]

This is still unaddressed.

[binitshrest]

This issue was closed accidentally. I am reopening this issue.

[binitshrest]

This issue was closed accidentally. I am reopening this issue.

Reopening

[SbloodyS]

+1

[ruanwenjun]

+1

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[boring-cyborg]

Awesome work, congrats on your first merged pull request!