Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapting partial code(file name start with P #1) to the sonar cloud rule #2187

Merged
merged 1 commit into from
Mar 15, 2020

Conversation

gabrywu
Copy link
Member

@gabrywu gabrywu commented Mar 15, 2020

No description provided.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (dev@61ebbf2). Click here to learn what that means.
The diff coverage is 18.51%.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev    #2187   +/-   ##
======================================
  Coverage       ?   29.84%           
  Complexity     ?     1630           
======================================
  Files          ?      336           
  Lines          ?    17795           
  Branches       ?     2239           
======================================
  Hits           ?     5311           
  Misses         ?    11920           
  Partials       ?      564
Impacted Files Coverage Δ Complexity Δ
.../server/worker/task/processdure/ProcedureTask.java 0% <0%> (ø) 0 <0> (?)
...dolphinscheduler/dao/utils/PostgrePerformance.java 0% <0%> (ø) 0 <0> (?)
...hinscheduler/dao/datasource/PostgreDataSource.java 0% <0%> (ø) 0 <0> (?)
...hinscheduler/dao/upgrade/PostgresqlUpgradeDao.java 0% <0%> (ø) 0 <0> (?)
...nscheduler/service/permission/PermissionCheck.java 0% <0%> (ø) 0 <0> (?)
...r/common/utils/process/ProcessBuilderForWin32.java 46% <0%> (ø) 32 <0> (?)
...ler/common/utils/placeholder/PlaceholderUtils.java 66.66% <100%> (ø) 3 <1> (?)
...ache/dolphinscheduler/server/utils/ParamUtils.java 83.87% <80%> (ø) 9 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61ebbf2...f675d9c. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Mar 15, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

21.1% 21.1% Coverage
2.4% 2.4% Duplication

Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo davidzollo merged commit 1658176 into apache:dev Mar 15, 2020
@gabrywu gabrywu deleted the fixSonarP_1 branch March 15, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants