-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]add presto datasource support #3308
Conversation
update .gitigonre to igonre some files
Good job, adding a new jar requires sending an email to dev and getting approval from PPMC. At the same time, you can refer to the following article to check by yourself first. |
done |
SonarCloud Quality Gate failed. 0 Bugs |
Good job, |
you need change the presto driver name com.facebook.presto.jdbc.PrestoDriver in presto driver configuration, not io.prestosql.jdbc.PrestoDriver when you use the facebook presto-jdbc jar , @rockxsj |
I have modify some code from this presto feature and submit another pull request [Feature]modify some cases from rockxsj:Feature-presto to add presto datasource support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
good job
I noticed that PR #3468 solved two bugs base on this PR,I will let him handle the potential conflict files and fix the bugs
Tips
What is the purpose of the pull request
update .gitigonre to igonre some files
add presto datasource support
Brief change log
Verify this pull request
This pull request is already covered by existing tests.