Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement-3369][api] Introduce ProjectService interface for more clear code #3384

Merged
merged 3 commits into from
Aug 16, 2020

Conversation

yangyichao-mango
Copy link
Contributor

What is the purpose of the pull request

Introduce ProjectService interface for clear code and make the function visibility of ProjectService more clear

Brief change log

  • Add ProjectService and ProjectServiceImpl
  • Add Builder design pattern for Project

Verify this pull request

This pull request is already covered by existing tests, such as (please describe tests).

@yangyichao-mango yangyichao-mango changed the title [Improvement][api] Introduce ProjectService interface for more clear code [Improvement-3369][api] Introduce ProjectService interface for more clear code Aug 2, 2020
@yangyichao-mango yangyichao-mango force-pushed the feature-projectservice branch 3 times, most recently from 8a44c2c to 9800b3d Compare August 15, 2020 04:05
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2020

Codecov Report

Merging #3384 into dev will decrease coverage by 0.05%.
The diff coverage is 72.72%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #3384      +/-   ##
============================================
- Coverage     35.76%   35.71%   -0.06%     
+ Complexity     2589     2587       -2     
============================================
  Files           449      449              
  Lines         21143    21176      +33     
  Branches       2591     2591              
============================================
+ Hits           7562     7563       +1     
- Misses        12873    12904      +31     
- Partials        708      709       +1     
Impacted Files Coverage Δ Complexity Δ
...rg/apache/dolphinscheduler/dao/entity/Project.java 35.52% <0.00%> (-27.27%) 18.00 <0.00> (ø)
...scheduler/api/service/impl/ProjectServiceImpl.java 87.27% <87.27%> (ø) 40.00 <40.00> (?)
...inscheduler/service/zk/CuratorZookeeperClient.java 62.16% <0.00%> (-2.71%) 7.00% <0.00%> (-1.00%)
...he/dolphinscheduler/common/thread/ThreadUtils.java 72.30% <0.00%> (+3.07%) 14.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b46db0...a0c6f36. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

79.4% 79.4% Coverage
0.2% 0.2% Duplication

Copy link
Contributor

@khadgarmage khadgarmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Jave-Chen Jave-Chen merged commit fe9967b into apache:dev Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants