Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement-3668][Server] ProcedureTask,SqlTask code structure standardization and checkstyle #3669

Closed

Conversation

zhuangchong
Copy link
Contributor

What is the purpose of the pull request

#3668
ProcedureTask,SqlTask code structure standardization and checkstyle

Brief change log

1.ProcedureTask, SqlTask code structure standardization
The constructor is used to load the environment context
The init() method handles task parameters
2.ProcedureTask, SqlTask code checkstyle

Verify this pull request

This pull request is code cleanup without any test coverage.


##拉取请求的目的是什么
ProcedureTask,SqlTask代码结构标准化和检查样式

##简要更改日志
1.ProcedureTask,SqlTask代码结构标准化
构造函数用于加载环境上下文
init()方法处理任务参数
2.ProcedureTask,SqlTask代码检查样式

##验证此拉取请求
此拉取请求是代码清除,没有任何测试范围。

@codecov-commenter
Copy link

Codecov Report

Merging #3669 into dev will increase coverage by 0.80%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #3669      +/-   ##
============================================
+ Coverage     39.14%   39.95%   +0.80%     
- Complexity     2829     2898      +69     
============================================
  Files           456      457       +1     
  Lines         21617    21669      +52     
  Branches       2622     2637      +15     
============================================
+ Hits           8462     8657     +195     
+ Misses        12365    12195     -170     
- Partials        790      817      +27     
Impacted Files Coverage Δ Complexity Δ
.../server/worker/task/processdure/ProcedureTask.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...lphinscheduler/server/worker/task/sql/SqlTask.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...server/master/processor/TaskResponseProcessor.java 70.83% <0.00%> (-16.67%) 2.00% <0.00%> (-1.00%)
...apache/dolphinscheduler/common/utils/NetUtils.java 44.18% <0.00%> (-8.57%) 26.00% <0.00%> (+6.00%) ⬇️
...ache/dolphinscheduler/remote/utils/NettyUtils.java 38.46% <0.00%> (-4.40%) 3.00% <0.00%> (+2.00%) ⬇️
...pache/dolphinscheduler/common/utils/JSONUtils.java 67.14% <0.00%> (-2.86%) 18.00% <0.00%> (ø%)
...inscheduler/service/zk/CuratorZookeeperClient.java 56.75% <0.00%> (-2.71%) 6.00% <0.00%> (-1.00%)
...er/master/processor/queue/TaskResponseService.java 54.90% <0.00%> (-1.97%) 6.00% <0.00%> (+1.00%) ⬇️
...nscheduler/api/service/ProcessInstanceService.java 73.83% <0.00%> (-0.47%) 36.00% <0.00%> (ø%)
...phinscheduler/remote/config/NettyClientConfig.java 52.00% <0.00%> (-0.39%) 7.00% <0.00%> (+1.00%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69201ac...eaddc82. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants