[FIX-3900][server] kill multi yarn app in one job #4042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenboo
reviewed
Nov 12, 2020
...hinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/utils/ProcessUtils.java
Show resolved
Hide resolved
lenboo
reviewed
Nov 12, 2020
lenboo
reviewed
Nov 16, 2020
...hinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/utils/ProcessUtils.java
Outdated
Show resolved
Hide resolved
lenboo
reviewed
Nov 16, 2020
...hinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/utils/ProcessUtils.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## dev #4042 +/- ##
============================================
+ Coverage 39.39% 39.49% +0.10%
- Complexity 2968 2981 +13
============================================
Files 467 467
Lines 22104 22113 +9
Branches 2712 2714 +2
============================================
+ Hits 8708 8734 +26
+ Misses 12589 12570 -19
- Partials 807 809 +2
Continue to review full report at Codecov.
|
lenboo
reviewed
Nov 17, 2020
| FileUtils.writeStringToFile(new File(commandFile), sb.toString(), StandardCharsets.UTF_8); | ||
| } | ||
|
|
||
| String runCmd = "sh " + commandFile; |
There was a problem hiding this comment.
is this "sh " can be instead?
I can find it elsewhere.
lenboo
reviewed
Nov 17, 2020
| mat = MACPATTERN.matcher(pids); | ||
| } | ||
| } else { | ||
| String pids = OSUtils.exeCmd("pstree -p " + processId); |
There was a problem hiding this comment.
i think this "pstree " can be extracted to one variable, then I can easily replace this variable.
lenboo
requested changes
Nov 17, 2020
davidzollo
reviewed
Nov 19, 2020
| } | ||
|
|
||
| logger.info("kill cmd:{}", runCmd); | ||
| Runtime.getRuntime().exec(runCmd); |
There was a problem hiding this comment.
please use OSUtils.exeCmd method instead，thx
davidzollo
requested changes
Nov 19, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
fix #3900 kill multi yarn app in one job
Brief change log
Verify this pull request