scale down observer #174
Merged
scale down observer #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not close pvc resource |
api/doris/v1/types.go
Outdated
|
|
||
| const ( | ||
| PHASE_INITIALIZING Phase = "initializing" | ||
| PHASE_OPERABLE Phase = "operable" |
There was a problem hiding this comment.
not phase name as operable
api/doris/v1/types.go
Outdated
| @@ -386,6 +419,7 @@ const ( | |||
| // +kubebuilder:subresource:status | |||
| // +kubebuilder:resource:shortName=dcr | |||
| // +kubebuilder:subresource:status | |||
| // +kubebuilder:printcolumn:name="ClusterPhase",type=string,JSONPath=`.status.clusterPhase.phase` | |||
| // +kubebuilder:printcolumn:name="FeStatus",type=string,JSONPath=`.status.feStatus.componentCondition.phase` | |||
pkg/common/utils/k8s/client.go
Outdated
| return &svc, nil | ||
| } | ||
|
|
||
| func GetPods(ctx context.Context, k8sclient client.Client, targetDCR dorisv1.DorisCluster) (corev1.PodList, error) { |
There was a problem hiding this comment.
GetPods is a common function, so why use fe filter in the function?
pkg/common/utils/k8s/client.go
Outdated
| } | ||
|
|
||
| for _, pod := range pods.Items { | ||
| fmt.Printf("pod --- Name: %s, pod: %s \n", pod.GetName(), pod.Status.PodIP) |
There was a problem hiding this comment.
this log format should not appear.
| } | ||
|
|
||
| // recycleBEResources pvc resource for be recycle | ||
| func (d *SubDefaultController) recycleBEResources(ctx context.Context, dcr *dorisv1.DorisCluster) error { |
There was a problem hiding this comment.
this is very very dangerous!!!!!! I have told you don't clear be resources.
| return err | ||
| } | ||
| if scaleNumber != -1 { | ||
| klog.Info("controlClusterPhaseAndPreOperation scale down observer task is not completed, %d tasks are left. ", -scaleNumber-1) |
| var mergeError error | ||
| for ; baseOrdinal > int(replicas); baseOrdinal-- { | ||
| pvc := resource.BuildPVC(volume, selector, dcr.Namespace, stsName, strconv.Itoa(baseOrdinal-1)) | ||
| if err := k8s.DeletePVC(ctx, d.K8sclient, dcr.Namespace, pvc.Name); err != nil { |
There was a problem hiding this comment.
not right, first get next delete.
| } | ||
|
|
||
| // sort fe by index and return top scaleNumber | ||
| func getTopFrontends(frontendMap map[int]*mysql.Frontend, scaleNumber int32) []*mysql.Frontend { |
There was a problem hiding this comment.
findNeedDeleteFrontends
| } | ||
|
|
||
| // deletePVCs will Loop to remove excess pvc | ||
| func (d *SubDefaultController) deletePVCs(ctx context.Context, dcr *dorisv1.DorisCluster, selector map[string]string, |
api/doris/v1/types.go
Outdated
| Phase Phase `json:"phase,omitempty"` | ||
|
|
||
| // describe change status task of the doris cluster need retry | ||
| Retry RetrySign `json:"retry,omitempty"` |
There was a problem hiding this comment.
cluster spec =每一个服务的spec，每一个pod的状态满足预期。
| return errors.New(fmt.Sprintf("There is a conflict in crd operation. currently, cluster Phase is %+v ", phase.Phase)) | ||
| } | ||
|
|
||
| if phase.Phase == v1.PHASE_OPERABLE || phase.Retry == v1.RETRY_OPERATOR_FE { |
There was a problem hiding this comment.
statefulset的pod的数量和所有pod的状态。
| ) | ||
|
|
||
| // ControlClusterPhaseAndPreOperation means Pre-operation and status control on the client side | ||
| func (fc *Controller) controlClusterPhaseAndPreOperation(ctx context.Context, cluster *v1.DorisCluster) error { |
There was a problem hiding this comment.
判断是否可以执行 缩容
- statefulset的replicas 和 pod 数量。
- 所有pod的状态。
| switch componentType { | ||
| case dorisv1.Component_FE: | ||
| return d.recycleFEResources(ctx, dcr) | ||
| case dorisv1.Component_BE: |
There was a problem hiding this comment.
case fe:
xxxx
default:
return
intelligentfu
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.