decrease memory usage when csv&gzip is on #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you done any tests? If so, can you post the results? |
@gnehil We do not add test case for this case. But in our scene the spark executor will be OOM when using original code. And it has been run successfully when using the optimised code with the same data and conf. |
gnehil
reviewed
Jun 27, 2024
| .format(format) | ||
| .sep(columnSeparator) | ||
| .delim(lineDelimiter) | ||
| .schema(schema) | ||
| .addDoubleQuotes(addDoubleQuotes).build, streamingPassthrough) | ||
| val content = recordBatchString.getContent |
There was a problem hiding this comment.
I guess that formatting the entire batch of data into a string object takes up extra memory, and copying between streams reduces the memory usage to a read buffer size.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #211 211
Problem Summary:
Use row input stream instead of StringBuilder when write to gzip outputstream.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...