[fix] Fix row_index position map access crash because filter is uninitialized. #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes a crash caused by accessing an uninitialized filter enum field in RowReaderOptionsPrivate. The crash was introduced in #369 when the filter field was added but not initialized in the constructor, leading to undefined behavior when the field was checked in conditional statements (e.g., getFilterTypeIdsSet()).
- Adds initialization of the
filterfield toColumnFilter_NONEin theRowReaderOptionsPrivateconstructor - Follows the same initialization pattern as the
selectionfield above it - Prevents crashes from accessing uninitialized memory when filter-related methods are called
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
morningman
approved these changes
Dec 5, 2025
16 tasks
morningman
pushed a commit
to apache/doris
that referenced
this pull request
Dec 8, 2025
…ered_map.at() (#58719) Fix row_index position unordered_map.at() crash because` RowReaderOptions::filter `is uninitialized. orc third-party changed: apache/doris-thirdparty#370
nagisa-kunhah
pushed a commit
to nagisa-kunhah/doris
that referenced
this pull request
Dec 14, 2025
…ered_map.at() (apache#58719) Fix row_index position unordered_map.at() crash because` RowReaderOptions::filter `is uninitialized. orc third-party changed: apache/doris-thirdparty#370
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[fix] Fix row_index position map access crash because filter is uninitialized.
#369 introduced this crash.
