modified based on comments

apache · Jul 12, 2024 · 5502b65 · 5502b65
1 parent 04108b9
commit 5502b65
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/...rc/main/java/org/apache/doris/nereids/rules/rewrite/UnCorrelatedApplyAggregateFilter.java b/...rc/main/java/org/apache/doris/nereids/rules/rewrite/UnCorrelatedApplyAggregateFilter.java
@@ -103,15 +103,15 @@ public List<Rule> buildRules() {
                 Utils.getUnCorrelatedExprs(correlatedPredicate, apply.getCorrelationSlot());
         newGroupby.addAll(agg.getGroupByExpressions());
         Map<Expression, Slot> unCorrelatedExprToSlot = Maps.newHashMap();
-        newAggOutput.addAll(newGroupby.stream().map(expression -> {
+        for (Expression expression : newGroupby) {
             if (expression instanceof Slot) {
-                return (NamedExpression) expression;
+                newAggOutput.add((NamedExpression) expression);
             } else {
                 Alias alias = new Alias(expression);
                 unCorrelatedExprToSlot.put(expression, alias.toSlot());
-                return alias;
+                newAggOutput.add(alias);
             }
-        }).collect(ImmutableList.toImmutableList()));
+        }
         correlatedPredicate = ExpressionUtils.replace(correlatedPredicate, unCorrelatedExprToSlot);
         LogicalAggregate newAgg = new LogicalAggregate<>(newGroupby, newAggOutput,
                 PlanUtils.filterOrSelf(ImmutableSet.copyOf(unCorrelatedPredicate), filter.child()));