Skip to content

Commit

Permalink
[bug](cherry-pick) fix bug of converting outer join probe block to nu…
Browse files Browse the repository at this point in the history
…llable (#25626)

* [refactor](join) improve join node output when build table rows is 0 (#23713)

* [Enhancement](filter) support only min/max runtime filter in BE (#25290)

this PR #25193 have achieve about FE.
eg: select count() from lineorder join supplier on lo_partkey < s_suppkey;
will have a max filter after build hash table , so could use it to filter probe table data.

* [bug](cherry-pick) fix bug of converting outer join probe block to nullable
  • Loading branch information
zhangstar333 authored Oct 19, 2023
1 parent 87863df commit 86b87ee
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions be/src/vec/exec/join/vhash_join_node.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -725,11 +725,12 @@ Status HashJoinNode::push(RuntimeState* /*state*/, vectorized::Block* input_bloc
_probe_columns.resize(probe_expr_ctxs_sz);

std::vector<int> res_col_ids(probe_expr_ctxs_sz);
RETURN_IF_ERROR(
_do_evaluate(*input_block, _probe_expr_ctxs, *_probe_expr_call_timer, res_col_ids));
if (_join_op == TJoinOp::RIGHT_OUTER_JOIN || _join_op == TJoinOp::FULL_OUTER_JOIN) {
_probe_column_convert_to_null = _convert_block_to_null(*input_block);
}
RETURN_IF_ERROR(
_do_evaluate(*input_block, _probe_expr_ctxs, *_probe_expr_call_timer, res_col_ids));

// TODO: Now we are not sure whether a column is nullable only by ExecNode's `row_desc`
// so we have to initialize this flag by the first probe block.
if (!_has_set_need_null_map_for_probe) {
Expand Down

0 comments on commit 86b87ee

Please sign in to comment.