[fix](regression) fix regression framework bug: if real test result i…

…s negative, it will miss check test result
apache · Oct 26, 2023 · 94f75ff · 94f75ff
1 parent c86fad7
commit 94f75ff
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/be/src/vec/functions/function_binary_arithmetic.h b/be/src/vec/functions/function_binary_arithmetic.h
@@ -79,7 +79,8 @@ struct OperationTraits {
  std::is_same_v<Op, DivideIntegralImpl<T, T>>;
  static constexpr bool can_overflow =
  (is_plus_minus || is_multiply) &&
- (IsDecimalV2<OpA> || IsDecimalV2<OpB> || IsDecimal256<OpA> || IsDecimal256<OpB>);
+ (IsDecimalV2<OpA> || IsDecimalV2<OpB> || IsDecimal128I<OpA> || IsDecimal128I<OpB> ||
+ IsDecimal256<OpA> || IsDecimal256<OpB>);
  static constexpr bool has_variadic_argument =
  !std::is_void_v<decltype(has_variadic_argument_types(std::declval<Op>()))>;
 };

diff --git a/...ession-test/framework/src/main/groovy/org/apache/doris/regression/util/OutputUtils.groovy b/...ession-test/framework/src/main/groovy/org/apache/doris/regression/util/OutputUtils.groovy
@@ -76,7 +76,7 @@ class OutputUtils {
  double expectDouble = Double.parseDouble(expectCell)
  double realDouble = Double.parseDouble(realCell)
 
- double realRelativeError = Math.abs(expectDouble - realDouble) / realDouble
+ double realRelativeError = Math.abs(expectDouble - realDouble) / Math.abs(realDouble)
  double expectRelativeError = 1e-8
 
  if (expectRelativeError < realRelativeError) {