Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement](Nereids)print slot name in explain string #12272

Merged
merged 8 commits into from
Sep 5, 2022

Conversation

morrySnow
Copy link
Contributor

@morrySnow morrySnow commented Sep 1, 2022

Proposed changes

Currently, explain string print all expression as slot id, e.g. <slot 1>.
This PR, print its name with slot id instead, e.g. column_a[#1]. For details:

  • print qualified table name for OlapScanNode
  • print NamedExpression name with SlotId instead of just SlotId
  • OlapScanNode's node name use "OlapScanNode" instead of table name

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • [] No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/nereids area/planner Issues or PRs related to the query planner labels Sep 1, 2022
@morrySnow morrySnow changed the title [enhancement](Nereids)print slot qualified name in explain string [enhancement](Nereids)print slot name in explain string Sep 1, 2022
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2022

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2022

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 2398cd3 into apache:master Sep 5, 2022
@morrySnow morrySnow deleted the enhance_explain branch September 5, 2022 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/nereids area/planner Issues or PRs related to the query planner reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants