Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor](refactor field) remove unused method #16068

Merged
merged 8 commits into from
Jan 19, 2023

Conversation

yiguolei
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@@ -452,125 +372,4 @@ TEST_F(TestRowCursor, FullKeyCmp) {
EXPECT_GT(compare_row(left, right_gt), 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use of undeclared identifier 'compare_row' [clang-diagnostic-error]

    EXPECT_GT(compare_row(left, right_gt), 0);
              ^

@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.29 seconds
load time: 493 seconds
storage size: 17122188075 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230118164735_clickbench_pr_83304.html

Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gabriel39 Gabriel39 merged commit 0b5e71d into apache:master Jan 19, 2023
dutyu pushed a commit to dutyu/doris that referenced this pull request Feb 1, 2023
@yiguolei yiguolei deleted the refactor_field branch March 30, 2023 10:21
dataroaring pushed a commit that referenced this pull request Jul 20, 2024
SegcompactionTest is disabled by #16068 due to some code clean up, it
needs to be repaired

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
dataroaring pushed a commit that referenced this pull request Jul 22, 2024
SegcompactionTest is disabled by #16068 due to some code clean up, it
needs to be repaired

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
zhannngchen added a commit to zhannngchen/incubator-doris that referenced this pull request Jul 22, 2024
SegcompactionTest is disabled by apache#16068 due to some code clean up, it
needs to be repaired

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
zhannngchen added a commit to zhannngchen/incubator-doris that referenced this pull request Aug 9, 2024
SegcompactionTest is disabled by apache#16068 due to some code clean up, it
needs to be repaired

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants