[Fix](planner)fix targetTypeDef NPE when value is null #18072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run buildall |
github-actions
bot
added
area/planner
|
run p0 |
|
run buildall |
|
run p0 |
morrySnow
approved these changes
Mar 27, 2023
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
morningman
pushed a commit
that referenced
this pull request
Mar 28, 2023
sql like: select * from (select *, null as top from v1)t where top = 5; select * from (select *, null as top from v1)t where top is not null; will cause NPE because targetTypeDef is null when value is null. Now we use cast target type to the targetTypeDef.
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 21, 2023
sql like: select * from (select *, null as top from v1)t where top = 5; select * from (select *, null as top from v1)t where top is not null; will cause NPE because targetTypeDef is null when value is null. Now we use cast target type to the targetTypeDef.
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Jul 12, 2023
sql like: select * from (select *, null as top from v1)t where top = 5; select * from (select *, null as top from v1)t where top is not null; will cause NPE because targetTypeDef is null when value is null. Now we use cast target type to the targetTypeDef.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
sql like:
select * from (select *, null as top from v1)t where top = 5;
select * from (select *, null as top from v1)t where top is not null;
will cause NPE because targetTypeDef is null when value is null. Now we use cast target type to the targetTypeDef.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...