Merge code to github #187
Merged
Merge code to github #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BiteTheDDDDt
pushed a commit
to BiteTheDDDDt/incubator-doris
that referenced
this pull request
Nov 16, 2021
starocean999
pushed a commit
to starocean999/incubator-doris
that referenced
this pull request
Jul 26, 2023
# Checklist * 内部Jira: * 修复PR： * master: * 1.2-lts: * 1.2-lts: * Doris-master： * [ ] 已修复 * [ ] 未修复 * [ ] 无问题 * Doris-1.2-lts： * [ ] 已修复 * [ ] 未修复 * [ ] 无问题 * Doris-1.1-lts： * [ ] 已修复 * [ ] 未修复 * [ ] 无问题
yiguolei
pushed a commit
that referenced
this pull request
Sep 28, 2023
Current multi-window plan generation has problem on the project sequence, for example: +--LogicalWindow ( windowExpressions=[avg(sum_sales#115) WindowSpec(...) AS `avg_monthly_sales`#116, rank() WindowSpec(...) AS `rn`#117], ...) and correspond physical plan is: +--PhysicalWindow[6572]@16 ( windowFrameGroup=(Funcs=[avg(sum_sales#115) WindowSpec(...) AS `avg_monthly_sales`#116], ... ) +--PhysicalWindow[6568]@29 ( windowFrameGroup=(Funcs=[rank() WindowSpec(...) AS `rn`#117], ...] ) If the final plan is generated as following: MultiCastDataSinks STREAM DATA SINK EXCHANGE ID: 20 HASH_PARTITIONED: rn[#208], i_brand[#202], cc_name[#203], i_category[#201] Before we eventually resolve the multi-window issue, we add a projection as following and force a mapping but this will not cover all potential problems. MultiCastDataSinks STREAM DATA SINK EXCHANGE ID: 20 HASH_PARTITIONED: rn[#219], i_brand[#213], cc_name[#214], i_category[#212] PROJECTIONS: i_category[#184], i_brand[#185], cc_name[#186], d_year[#187], d_moy[#188], sum_sales[#189], avg_monthly_sales[#191], rn[#190] PROJECTION TUPLE: 20
vinlee19
pushed a commit
to vinlee19/doris
that referenced
this pull request
Oct 7, 2023
…24912) Current multi-window plan generation has problem on the project sequence, for example: +--LogicalWindow ( windowExpressions=[avg(sum_sales#115) WindowSpec(...) AS `avg_monthly_sales`apache#116, rank() WindowSpec(...) AS `rn`apache#117], ...) and correspond physical plan is: +--PhysicalWindow[6572]@16 ( windowFrameGroup=(Funcs=[avg(sum_sales#115) WindowSpec(...) AS `avg_monthly_sales`apache#116], ... ) +--PhysicalWindow[6568]@29 ( windowFrameGroup=(Funcs=[rank() WindowSpec(...) AS `rn`apache#117], ...] ) If the final plan is generated as following: MultiCastDataSinks STREAM DATA SINK EXCHANGE ID: 20 HASH_PARTITIONED: rn[apache#208], i_brand[apache#202], cc_name[apache#203], i_category[apache#201] Before we eventually resolve the multi-window issue, we add a projection as following and force a mapping but this will not cover all potential problems. MultiCastDataSinks STREAM DATA SINK EXCHANGE ID: 20 HASH_PARTITIONED: rn[apache#219], i_brand[apache#213], cc_name[apache#214], i_category[apache#212] PROJECTIONS: i_category[apache#184], i_brand[apache#185], cc_name[apache#186], d_year[apache#187], d_moy[apache#188], sum_sales[apache#189], avg_monthly_sales[apache#191], rn[apache#190] PROJECTION TUPLE: 20
bobhan1
added a commit
to bobhan1/doris
that referenced
this pull request
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal commit 95787f8be1fd0ff215708fb0f49997b632876586