Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](thirdparty) fix opentelemetry error message compiling with ubsan #18912

Merged
merged 1 commit into from
May 5, 2023

Conversation

luozenglin
Copy link
Contributor

Proposed changes

Issue Number: close #18907
related: open-telemetry/opentelemetry-cpp#1815

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@luozenglin
Copy link
Contributor Author

run buildall

@luozenglin
Copy link
Contributor Author

run buildall

@luozenglin
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@zclllyybb
Copy link
Contributor

run p1

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

PR approved by at least one committer and no changes requested.

@luozenglin luozenglin merged commit 5c8ecfb into apache:master May 5, 2023
@luozenglin luozenglin deleted the telemetry_fix branch May 5, 2023 11:09
Reminiscent pushed a commit to Reminiscent/doris that referenced this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] BE report undefined behavior under ubsan about opentelemetry
4 participants