Skip to content

[fix]Do filter before projection on multi cast sender #21411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morrySnow merged 1 commit into from
Jul 1, 2023
Merged

[fix]Do filter before projection on multi cast sender #21411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions be/src/pipeline/exec/multi_cast_data_stream_source.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,19 +86,19 @@ Status MultiCastDataStreamerSourceOperator::get_block(RuntimeState* state, vecto
SourceState& source_state) {
bool eos = false;
_multi_cast_data_streamer->pull(_consumer_id, block, &eos);

if (!_conjuncts.empty()) {
RETURN_IF_ERROR(
vectorized::VExprContext::filter_block(_conjuncts, block, block->columns()));
}

if (!_output_expr_contexts.empty()) {
vectorized::Block output_block;
RETURN_IF_ERROR(vectorized::VExprContext::get_output_block_after_execute_exprs(
_output_expr_contexts, *block, &output_block));
materialize_block_inplace(output_block);
block->swap(output_block);
}

if (!_conjuncts.empty()) {
RETURN_IF_ERROR(
vectorized::VExprContext::filter_block(_conjuncts, block, block->columns()));
}

if (eos) {
source_state = SourceState::FINISHED;
}
Expand Down
1 change: 1 addition & 0 deletions be/src/vec/exec/vselect_node.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ class VSelectNode final : public ExecNode {
Status get_next(RuntimeState* state, vectorized::Block* block, bool* eos) override;
Status close(RuntimeState* state) override;
Status pull(RuntimeState* state, vectorized::Block* output_block, bool* eos) override;

private:
// true if last get_next() call on child signalled eos
bool _child_eos;
Expand Down