-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement](statistics)Improve show analyze performance. #22484
Conversation
run buildall |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
LGTM |
The origin show analyze code would traverse the task id to task map for each job to get all the tasks for this job, which is very slow.
This pr keep the task ids for each job in the job info class, so that we can get the tasks by task ids directly.
To show 1100+ jobs with 11000+ tasks, the time costing is reduced from 0.14s to 0.01s.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...