-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](planner)fix incorrect nullable in ctas. #22770
Conversation
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
b5c72a2
to
a396324
Compare
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
ctas with outer join like ```sql create table a ( id int not null, name varchar(20) not null ) distributed by hash(id) buckets 4 properties ( "replication_num"="1" ); create table b ( id int not null, age int not null ) distributed by hash(id) buckets 4 properties ( "replication_num"="1" ); insert into a values(1, 'ww'), (2, 'zs'); insert into b values(1, 22); create table c properties("replication_num"="1") as select a.id, a.name, b.age from a left join b on a.id = b.id; ``` the column 'age' in c is not null, but nullable is expected, we fix it by use the nullable mode of the outputs of root plan fragment.
ctas with outer join like ```sql create table a ( id int not null, name varchar(20) not null ) distributed by hash(id) buckets 4 properties ( "replication_num"="1" ); create table b ( id int not null, age int not null ) distributed by hash(id) buckets 4 properties ( "replication_num"="1" ); insert into a values(1, 'ww'), (2, 'zs'); insert into b values(1, 22); create table c properties("replication_num"="1") as select a.id, a.name, b.age from a left join b on a.id = b.id; ``` the column 'age' in c is not null, but nullable is expected, we fix it by use the nullable mode of the outputs of root plan fragment.
ctas with outer join like ```sql create table a ( id int not null, name varchar(20) not null ) distributed by hash(id) buckets 4 properties ( "replication_num"="1" ); create table b ( id int not null, age int not null ) distributed by hash(id) buckets 4 properties ( "replication_num"="1" ); insert into a values(1, 'ww'), (2, 'zs'); insert into b values(1, 22); create table c properties("replication_num"="1") as select a.id, a.name, b.age from a left join b on a.id = b.id; ``` the column 'age' in c is not null, but nullable is expected, we fix it by use the nullable mode of the outputs of root plan fragment.
if previous PR apache#22770. we try to fix incorrect nullable in target table. However we changed nullable info of column in source table unexpectly
…ble (apache#24767) if previous PR apache#22770. we try to fix incorrect nullable in target table. However we changed nullable info of column in source table unexpectly
…ble (apache#24767) if previous PR apache#22770. we try to fix incorrect nullable in target table. However we changed nullable info of column in source table unexpectly
Proposed changes
Issue Number: close #xxx
ctas with outer join like
the column 'age' in c is not null, but nullable is expected, we fix it by use the nullable mode of the outputs of root plan fragment.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...