Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore](docs)Add SSL Faq #22956

Merged
merged 2 commits into from
Aug 15, 2023
Merged

[Chore](docs)Add SSL Faq #22956

merged 2 commits into from
Aug 15, 2023

Conversation

irenesrl
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@irenesrl
Copy link
Contributor Author

run buildall

hf200012
hf200012 previously approved these changes Aug 14, 2023
Copy link
Contributor

@hf200012 hf200012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JNSimba
JNSimba previously approved these changes Aug 14, 2023
Copy link
Member

@JNSimba JNSimba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Aug 14, 2023
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@irenesrl irenesrl dismissed stale reviews from JNSimba and hf200012 via 0abe204 August 14, 2023 10:34
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Aug 14, 2023
@CalvinKirs
Copy link
Member

run buildall

Copy link
Member

@JNSimba JNSimba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JNSimba JNSimba merged commit 27f5b62 into apache:master Aug 15, 2023
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 15, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants