Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix](PhysicalPlanTranslator) forget setPushDownAggNoGrouping in OlapScanNode #23675

Merged
merged 2 commits into from
Aug 31, 2023
Merged

[Fix](PhysicalPlanTranslator) forget setPushDownAggNoGrouping in OlapScanNode #23675

merged 2 commits into from
Aug 31, 2023

Conversation

airborne12
Copy link
Member

Proposed changes

Issue Number: close #xxx

PR #23402 introduces a bug by forgetting to set setPushDownAggNoGrouping in OlapScanNode.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@airborne12
Copy link
Member Author

run buildall

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.89 seconds
stream load tsv: 550 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162273617 Bytes

@airborne12
Copy link
Member Author

run buildall

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.6 seconds
stream load tsv: 553 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17161963271 Bytes

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 31, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@starocean999 starocean999 merged commit ab85fb3 into apache:master Aug 31, 2023
airborne12 added a commit to airborne12/apache-doris that referenced this pull request Aug 31, 2023
@airborne12
[Fix](PhysicalPlanTranslator) forget setPushDownAggNoGrouping in Olap…
3e7d64e 
…ScanNode (apache#23675)

* [Fix](PhysicalPlanTranslator) forget setPushDownAggNoGrouping in OlapScanNode

* use relation id instead of table id
xiaokang pushed a commit that referenced this pull request Aug 31, 2023
@airborne12
[Fix](PhysicalPlanTranslator) forget setPushDownAggNoGrouping in Olap…
140e6d1 
…ScanNode (#23675) (#23699)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrySnow morrySnow morrySnow approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.2-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@airborne12 @hello-stephen @starocean999 @morrySnow @xiaokang