Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[debug](FileCache) fail over to remote file reader if local cache failed #24097

Merged
merged 1 commit into from
Sep 10, 2023
Merged

[debug](FileCache) fail over to remote file reader if local cache failed #24097

merged 1 commit into from
Sep 10, 2023

Conversation

AshinGau
Copy link
Member

@AshinGau AshinGau commented Sep 8, 2023

Proposed changes

Fail over to remote file reader even if local file cache failed. This operation can increase the robustness of file cache.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@AshinGau
Copy link
Member Author

AshinGau commented Sep 8, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.93% (7895/21379)
Line Coverage: 28.93% (63358/218970)
Region Coverage: 27.87% (32897/118017)
Branch Coverage: 24.46% (16896/69070)
Coverage Report: http://coverage.selectdb-in.cc/coverage/8ef368cca51aab60092f0525884cf78a0130d1e8_8ef368cca51aab60092f0525884cf78a0130d1e8/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.22 seconds
stream load tsv: 532 seconds loaded 74807831229 Bytes, about 134 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162207106 Bytes

morningman
morningman approved these changes Sep 10, 2023
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 10, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

yiguolei
yiguolei approved these changes Sep 10, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 71645a3 into apache:master Sep 10, 2023
xiaokang pushed a commit that referenced this pull request Sep 10, 2023
@AshinGau @xiaokang
[debug](FileCache) fail over to remote file reader if local cache fai…
56d8444 
…led (#24097)

Fail over to remote file reader even if local file cache failed. This operation can increase the robustness of file cache.
@xiaokang xiaokang mentioned this pull request Sep 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiguolei yiguolei yiguolei approved these changes

@morningman morningman morningman approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.2-merged p0_b reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AshinGau @doris-robot @morningman @yiguolei @xiaokang