Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature](multi-catalog) Support hadoop viewfs. #24168

Merged
merged 1 commit into from
Sep 12, 2023
Merged

[Feature](multi-catalog) Support hadoop viewfs. #24168

merged 1 commit into from
Sep 12, 2023

Conversation

kaka11chen
Copy link
Contributor

Proposed changes

Feature

Support hadoop viewfs.

Test

  • Regression tests:

    • hive viewfs test.
    • tvf viewfs test.

  • Broker load with broker and with hdfs tests manually.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@kaka11chen
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.92% (7917/21441)
Line Coverage: 28.96% (63618/219691)
Region Coverage: 27.89% (33002/118340)
Branch Coverage: 24.46% (16944/69272)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a2aa594b996738375bb997ef1120ddc944121647_a2aa594b996738375bb997ef1120ddc944121647/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.26 seconds
stream load tsv: 590 seconds loaded 74807831229 Bytes, about 120 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162415307 Bytes

@kaka11chen
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.92% (7917/21443)
Line Coverage: 28.95% (63605/219700)
Region Coverage: 27.88% (32993/118345)
Branch Coverage: 24.45% (16937/69272)
Coverage Report: http://coverage.selectdb-in.cc/coverage/722ca943b7904cb92a8a10c6801a6fca27fbcf3b_722ca943b7904cb92a8a10c6801a6fca27fbcf3b/report/index.html

morningman
morningman approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 11, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.75 seconds
stream load tsv: 584 seconds loaded 74807831229 Bytes, about 122 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162216590 Bytes

@kaka11chen
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.93% (7919/21443)
Line Coverage: 28.97% (63659/219727)
Region Coverage: 27.89% (33030/118428)
Branch Coverage: 24.47% (16966/69328)
Coverage Report: http://coverage.selectdb-in.cc/coverage/adbb8b9b0d97901d15be6aca8b9ea1d2d974df81_adbb8b9b0d97901d15be6aca8b9ea1d2d974df81/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.6 seconds
stream load tsv: 580 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162403389 Bytes

morningman
morningman approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Jibing-Li
Jibing-Li approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@Jibing-Li Jibing-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 9df72a9 into apache:master Sep 12, 2023
@xiaokang xiaokang added usercase Important user case type label merge_conflict labels Sep 13, 2023
@kaka11chen kaka11chen mentioned this pull request Sep 13, 2023
Merged
yiguolei pushed a commit that referenced this pull request Sep 14, 2023
@kaka11chen
[Feature](multi-catalog) Support hadoop viewfs. (#24337)
d33ccbc 
kaka11chen
Contributor
kaka11chen commented 9 hours ago
Proposed changes
Merge from #24168
@xiaokang xiaokang mentioned this pull request Sep 30, 2023
Open
@xiaokang xiaokang mentioned this pull request Dec 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jibing-Li Jibing-Li Jibing-Li approved these changes

@wuwenchi wuwenchi wuwenchi approved these changes

@morningman morningman morningman approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.2-merged merge_conflict reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kaka11chen @doris-robot @morningman @wuwenchi @Jibing-Li @xiaokang @yiguolei