Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](merge-on-write) fix duplicate key in schema change #24782

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

liaoxin01
Copy link
Contributor

@liaoxin01 liaoxin01 commented Sep 22, 2023

Proposed changes

During the schema change, the load of new tables did not calculate the delete bitmap, which will be calculated when the schema change is completed. However, due to the lock window issue, the invisible rowset was not calculated at the end of the schema change. So it may result in duplicate keys.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@liaoxin01
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.41% (8023/22038)
Line Coverage: 28.69% (64445/224640)
Region Coverage: 27.60% (33474/121299)
Branch Coverage: 24.25% (17126/70616)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4e646daf97e2e1d82cb58c733781db771cadd0d6_4e646daf97e2e1d82cb58c733781db771cadd0d6/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.37 seconds
stream load tsv: 551 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17161964870 Bytes

Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 22, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaokang xiaokang merged commit 3bf95b2 into apache:master Sep 22, 2023
@xiaokang xiaokang mentioned this pull request Sep 28, 2023
@liaoxin01 liaoxin01 deleted the fix_sc_dup branch February 6, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.2-merged p0_w reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants