Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](Nereids) should not replace slot by Alias when do NormalizeSlot #24928

Merged
merged 1 commit into from
Sep 28, 2023

Commits on Sep 28, 2023

  1. [fix](Nereids) should not replace slot by Alias when do NormalizeSlot

    when we do NormalizeToSlot, we pushed complex expression and only remain
    slot of it. When we do this, we collect alias and their child and
    compute its child in bottom project, remain the result slot in current
    node. for example
    
    Window(max(...), c1 as a1)
    
    after normalization, we get
    
    Window(max(...), a1)
    +-- Project(..., c1 as a1)
    
    But, in some cases, we remove some SlotReference by mistake, for example
    
    Window(max(...), c1, c1 as a1)
    
    after normalization, we get
    
    Window(max(...), a1)
    +-- Project(..., c1 as a1)
    
    we lost the SlotReference c1. This PR fix this problem. After this Pr,
    we get
    
    Window(max(...), c1, a1)
    +-- Project(..., c1, c1 as a1)
    morrySnow committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    e046645 View commit details
    Browse the repository at this point in the history