Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](Nereids) fix toSql of date literal #25243

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

keanji-x
Copy link
Contributor

Proposed changes

toSql should return '2023-2-1 ' for DateLiteral 2023-2-1

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@keanji-x keanji-x changed the title [fix](Nereids) fix tosql of date literal [fix](Nereids) fix toSql of date literal Oct 10, 2023
@keanji-x
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.71 seconds
stream load tsv: 575 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162513877 Bytes

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 10, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@jackwener jackwener merged commit 47578c0 into apache:master Oct 11, 2023
@keanji-x keanji-x deleted the fix_date_tosql branch October 11, 2023 05:09
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
toSql should return '2023-2-1 ' for DateLiteral 2023-2-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.3-merged merge_conflict reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants