Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](backup) fix backup fail on s3 #25496

Merged
merged 2 commits into from
Oct 18, 2023
Merged

[fix](backup) fix backup fail on s3 #25496

merged 2 commits into from
Oct 18, 2023

Conversation

morningman
Copy link
Contributor

Proposed changes

The s3 client properties are not passed to BE correctly.
The test cases will be added later

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morningman morningman added dev/2.0.3 usercase Important user case type label labels Oct 16, 2023
@morningman
Copy link
Contributor Author

run buildall

@morningman morningman mentioned this pull request Oct 16, 2023
Closed
@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.08 seconds
stream load tsv: 555 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162459857 Bytes

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

wsjz
wsjz approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@wsjz wsjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.48 seconds
stream load tsv: 554 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162299825 Bytes

wsjz
wsjz approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@wsjz wsjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 18, 2023
@morningman morningman merged commit db16a14 into apache:master Oct 18, 2023
23 checks passed
xiaokang pushed a commit that referenced this pull request Oct 18, 2023
@morningman @xiaokang
[fix](backup) fix backup fail on s3 (#25496)
f3bb9b3 
The s3 client properties are not passed to BE correctly.
The test cases will be added later
@morningman morningman mentioned this pull request Oct 23, 2023
Merged
AshinGau pushed a commit that referenced this pull request Oct 25, 2023
@morningman
[fix](backup) missing use_path_style properties for minio (#25803)
0dcbc5e 
Follow #25496.
In #25496, I fixed the issue that the aws s3 properties are invalid when passing from FE to BE.
But it missed the `use_path_style` property, which is useful for minio access.
This PR fix it.
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@morningman
[fix](backup) fix backup fail on s3 (apache#25496)
1c4a48d 
The s3 client properties are not passed to BE correctly.
The test cases will be added later
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@morningman
[fix](backup) missing use_path_style properties for minio (apache#25803)
4addf4c 
Follow apache#25496.
In apache#25496, I fixed the issue that the aws s3 properties are invalid when passing from FE to BE.
But it missed the `use_path_style` property, which is useful for minio access.
This PR fix it.
wsjz pushed a commit to wsjz/incubator-doris that referenced this pull request Nov 19, 2023
@morningman @wsjz
[fix](backup) fix backup fail on s3 (apache#25496)
4bf6b64 
The s3 client properties are not passed to BE correctly.
The test cases will be added later
wsjz pushed a commit to wsjz/incubator-doris that referenced this pull request Nov 19, 2023
@morningman @wsjz
[fix](backup) missing use_path_style properties for minio (apache#25803)
c787cac 
Follow apache#25496.
In apache#25496, I fixed the issue that the aws s3 properties are invalid when passing from FE to BE.
But it missed the `use_path_style` property, which is useful for minio access.
This PR fix it.
@xiaokang xiaokang mentioned this pull request Dec 4, 2023
Open
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@morningman
[fix](backup) fix backup fail on s3 (apache#25496)
9fdfffb 
The s3 client properties are not passed to BE correctly.
The test cases will be added later
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@morningman
[fix](backup) missing use_path_style properties for minio (apache#25803)
744c8dd 
Follow apache#25496.
In apache#25496, I fixed the issue that the aws s3 properties are invalid when passing from FE to BE.
But it missed the `use_path_style` property, which is useful for minio access.
This PR fix it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w41ter w41ter w41ter approved these changes

@wsjz wsjz wsjz approved these changes

@AshinGau AshinGau AshinGau approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.3-merged reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@morningman @doris-robot @w41ter @wsjz @AshinGau @xiaokang